Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDP-1068] fix: output Azure Entra ID workload identity's client ID in annotations #47

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[IDP-1068] fix: output Azure Entra ID workload identity's client ID in annotations #47

merged 2 commits into from
Mar 21, 2024

Conversation

felpel
Copy link
Contributor

@felpel felpel commented Mar 21, 2024 •
edited
Loading

Description of changes

  • Output the client ID for Azure Entra ID Workload Identity in the ServiceAccount's annotations rather than labels to conform with its expectations and prevent configuration overrides in repositories that would consume the current chart
  • Edit the pipeline to also test chart deployment on Kubernetes 1.27

Breaking changes

N/A

@felpel
fix: ensure Azure Entra ID workload identity's client ID renders in s…
f23d303 
…ervice account's annotations rather than labels
@felpel felpel requested a review from a team as a code owner March 21, 2024 14:50
starcraft66
starcraft66 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@starcraft66 starcraft66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the client id is indeed meant to be an annotation according to the docs.

@felpel felpel force-pushed the feature/IDP-1068_fix_azure_workload_identity_client_id branch from 9f21d03 to 66b3ddd Compare March 21, 2024 15:02
@starcraft66 starcraft66 self-requested a review March 21, 2024 15:09
starcraft66
starcraft66 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@starcraft66 starcraft66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felpel felpel merged commit 0f9df1e into main Mar 21, 2024
8 checks passed
@starcraft66 starcraft66 deleted the feature/IDP-1068_fix_azure_workload_identity_client_id branch March 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starcraft66 starcraft66 starcraft66 approved these changes

Assignees

@starcraft66 starcraft66

@heqianwang heqianwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felpel @starcraft66 @heqianwang